cmd: use fee cut instead of fee share in the CLI #1848
Merged
+21
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyriediculous
force-pushed
the
nv/fee-cut
branch
from
89147e7 to
ec9844d
Compare
yondonfu
requested changes
Apr 21, 2021
kyriediculous
force-pushed
the
nv/fee-cut
branch
from
ec9844d to
0575c41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Use fee cut instead of fee share for user facing language in the CLI
How did you test each of these updates (required)
Manual test on rinkeby on all affected code paths
Does this pull request close any open issues?
Fixes #1808
Checklist:
makeruns successfully./test.shpass